Code Review Can Be Better
8 months ago
- #code-review
- #github
- #git
- GitHub's code review process is widely criticized, especially for poor support of stacked pull requests and interdiff reviews.
- The author prefers local code review over web interfaces, highlighting benefits like faster performance and personalized workflows.
- git-review was created to store review state in the repository itself, using commits for comments and feedback.
- Despite the promising concept, git-review faced challenges with code modifications and conflicts during reviews.
- Upcoming Git features like Change-Id might offer better solutions for tracking commit revisions and interdiff reviews.
- The article mentions alternative tools and systems (Fossil, Gerrit's NoteDb, git-bug, git-appraise, prr) that store review or issue data in repositories.
- Jane Street's internal code review system is cited as an example of a more effective approach.