Why I'm declining your AI generated MR
15 days ago
- #AI-generated code
- #code review
- #software development
- Declining AI-generated merge requests (MRs) when they harm the team or project.
- Common issues include unnecessary code, lack of language basics, documentation spam, inconsistency, edge case overload, and pointless dependencies.
- Code reviews (CRs) aim to improve authors and reviewers, ensure sanity checks, reduce mental load, and maintain consistency.
- AI misuse in MRs can violate CR goals, such as learning, project improvement, and responsibility.
- Exceptions for accepting AI-generated MRs include temporary code, explanations for AI use, and non-core features.
- Challenges in confronting juniors about AI misuse and balancing support vs. rejection.
- Need for evolving guidelines as AI tools and practices develop.