Reviewing code you didn't write
9 hours ago
- Reviewing code is a separate skill from writing code, focused on finding critical issues that determine whether the work should ship.
- Reconstruct the change's context by checking out the branch, reading tests, and understanding the intent from tickets or design notes.
- Review the core path first: evaluate the approach and check for duplication before diving into details.
- Order review comments by priority: approach, then correctness, failure, security, and evidence; block merges only for critical issues and use 'nit:' for preferences.
- When reviewing AI-generated code, be skeptical of invented APIs, unnecessary abstractions, and overly complete test suites; verify against the task and project rules.
- Improve review skills by studying merged PRs and seeking feedback from other engineers on your own review comments.